third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 1516683002: Introducing LayoutObject::mapToVisibleRectInContainerSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 1516683002: Introducing LayoutObject::mapToVisibleRectInContainerSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutInline.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.cpp b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

index 58f6568fd484ab97715f23e4fbfa2cdac89ef240..621e12b1d99182fba870a6d00cf90e6e81023df2 100644

--- a/third_party/WebKit/Source/core/layout/LayoutInline.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

@@ -1101,7 +1101,7 @@ void LayoutInline::mapRectToPaintInvalidationBacking(const LayoutBoxModelObject*

// FIXME: We ignore the lightweight clipping rect that controls use, since if |o| is in mid-layout,

// its controlClipRect will be wrong. For overflow clip we use the values cached by the layer.

rect.setLocation(topLeft);

- if (o->hasOverflowClip()) {

+ if (o != paintInvalidationContainer && o->hasOverflowClip()) {

LayoutBox* containerBox = toLayoutBox(o);

containerBox->applyCachedClipAndScrollOffsetForPaintInvalidation(rect);

if (rect.isEmpty())