Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1516643002: XFA: Revert UTF16LE_Encode changes (Closed)

Created:
5 years ago by Oliver Chang
Modified:
5 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Revert UTF16LE_Encode changes Revert "Fix embedder test failures introduced by commit c70b19aad245" This reverts commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb. Revert "Fix invalid buffer length set in CFX_WideString::UTF16LE_Encode()" This reverts commit c70b19aad245fb1ed39bf8c264d991555f4c5a58. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/35e68a5275f2d1e6819c773f0f367e225a0d5961

Patch Set 1 #

Patch Set 2 : don't revert legitimate fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -43 lines) Patch
M core/src/fxcrt/fx_basic_wstring.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 4 chunks +22 lines, -19 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Oliver Chang
ptal. I'm assuming this will cause pdfium:275 to break again though.
5 years ago (2015-12-09 20:01:02 UTC) #1
Oliver Chang
On 2015/12/09 at 20:01:02, Oliver Chang wrote: > ptal. I'm assuming this will cause pdfium:275 ...
5 years ago (2015-12-09 20:05:50 UTC) #3
Oliver Chang
Please see patchset #2. Un-reverted some legitimate fixes.
5 years ago (2015-12-09 20:16:12 UTC) #4
Tom Sepez
lgtm
5 years ago (2015-12-09 20:39:15 UTC) #5
Oliver Chang
5 years ago (2015-12-09 20:44:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
35e68a5275f2d1e6819c773f0f367e225a0d5961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698