build/common.gypi - Issue 151663004: Set -fmsc-version for the Windows Clang build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 151663004: Set -fmsc-version for the Windows Clang build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 07a420b950fa4df2fe0cf7915b5ae39da6894b61..de97161f1e809ae6e4a83666ce4c51d89de1e2cf 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -4669,6 +4669,9 @@

'AdditionalOptions': [

'/fallback',

+ # The Clang build expects to fall back to VS 2013.

+ '-fmsc-version=1800',

Reid Kleckner 2014/02/11 19:32:12 Does gyp know the version of MSVC that's being use

scottmg 2014/02/11 20:09:07 Yes, it's always set. GYP_MSVS_VERSION will be one

# Many files use intrinsics without including this header.

# TODO(hans): Fix those files, or move this to sub-GYPs.

'/FIIntrin.h',

« no previous file with comments | « no previous file | no next file » | no next file with comments »