Set -fmsc-version for the Windows Clang build

Set -fmsc-version for the Windows Clang build

It's important that -fmsc-version matches the version of VS that we're
falling back to. In practive, this should always be 2013 these days.

BUG=82385
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250511

[Reid Kleckner, 2014-02-11 19:32:12]

https://codereview.chromium.org/151663004/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/151663004/diff/1/build/common.gypi#newcode4673
build/common.gypi:4673: '-fmsc-version=1800',
Does gyp know the version of MSVC that's being used here?  Can we use that
instead?

[hans, 2014-02-11 19:42:30]

On 2014/02/11 19:32:12, Reid Kleckner wrote:
> https://codereview.chromium.org/151663004/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
> https://codereview.chromium.org/151663004/diff/1/build/common.gypi#newcode4673
> build/common.gypi:4673: '-fmsc-version=1800',
> Does gyp know the version of MSVC that's being used here?  Can we use that
> instead?

I wish it did, but I don't think it does :/

There's a MSVS_VERSION variable, but I couldn't figure out if that always gets
set.

+scottmg who might know.

[hans, 2014-02-11 19:42:53]

+scottmg for real this time

[scottmg, 2014-02-11 20:09:07]

https://codereview.chromium.org/151663004/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/151663004/diff/1/build/common.gypi#newcode4673
build/common.gypi:4673: '-fmsc-version=1800',
On 2014/02/11 19:32:12, Reid Kleckner wrote:
> Does gyp know the version of MSVC that's being used here?  Can we use that
> instead?

Yes, it's always set. GYP_MSVS_VERSION will be one of "2010", "2010e", "2013",
or "2013e".

[hans, 2014-02-11 20:43:08]

On 2014/02/11 20:09:07, scottmg wrote:
> https://codereview.chromium.org/151663004/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
> https://codereview.chromium.org/151663004/diff/1/build/common.gypi#newcode4673
> build/common.gypi:4673: '-fmsc-version=1800',
> On 2014/02/11 19:32:12, Reid Kleckner wrote:
> > Does gyp know the version of MSVC that's being used here?  Can we use that
> > instead?
> 
> Yes, it's always set. GYP_MSVS_VERSION will be one of "2010", "2010e", "2013",
> or "2013e".

Cool, I'll just use that then.

[hans, 2014-02-11 20:58:59]

New version. Please take another look.

[scottmg, 2014-02-11 21:04:12]

lgtm

[hans, 2014-02-11 21:18:22]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-02-11 21:19:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/151663004/90001

[commit-bot: I haz the power, 2014-02-11 21:22:02]

Change committed as 250511