Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1516593002: Adding hendrikw@ as an OWNER of WebVR (Closed)

Created:
5 years ago by bajones
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews, darin-cc_chromium.org, jam, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding hendrikw@ as an OWNER of WebVR Hendrik is familiar with Chrome and Blink, but is also involved in VR development which makes him a good choice for WebVR reviews. Committed: https://crrev.com/5b728ecefe8237d7bdfa078c25dc3209d48ff669 Cr-Commit-Position: refs/heads/master@{#364799}

Patch Set 1 #

Patch Set 2 : Removed Blink OWNERS addition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/vr/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bajones
5 years ago (2015-12-09 17:42:39 UTC) #2
hendrikw
On 2015/12/09 17:42:39, bajones wrote: LGTM :)
5 years ago (2015-12-10 16:59:08 UTC) #3
bajones
Small follow up hendrikw@: There was some concerns expressed that your backlog of Blink commits ...
5 years ago (2015-12-11 19:54:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516593002/20001
5 years ago (2015-12-11 19:56:47 UTC) #7
Ken Russell (switch to Gerrit)
LGTM
5 years ago (2015-12-11 20:19:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-11 20:58:47 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-11 20:59:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b728ecefe8237d7bdfa078c25dc3209d48ff669
Cr-Commit-Position: refs/heads/master@{#364799}

Powered by Google App Engine
This is Rietveld 408576698