Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1516563002: DM: tally notes at the end rather than showing them as they finish. (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: tally notes at the end rather than showing them as they finish. This should make the (veto) and (skipped: ) both less verbose and easier to grok. Looks like this'll bring the log files down from ~50M to ~1.5M. BUG=skia: Committed: https://skia.googlesource.com/skia/+/bc4e003d39636ec7fbc80511828b5c2b327e9f13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M dm/DM.cpp View 5 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516563002/1
5 years ago (2015-12-09 16:21:15 UTC) #2
mtklein_C
5 years ago (2015-12-09 16:31:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 16:33:31 UTC) #7
scroggo
lgtm
5 years ago (2015-12-09 16:36:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516563002/1
5 years ago (2015-12-09 16:36:59 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-09 16:37:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bc4e003d39636ec7fbc80511828b5c2b327e9f13

Powered by Google App Engine
This is Rietveld 408576698