third_party/re2/re2/testing/exhaustive2_test.cc - Issue 1516543002: Update re2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/re2/re2/testing/exhaustive2_test.cc

Issue 1516543002: Update re2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/re2/re2/testing/exhaustive2_test.cc

diff --git a/third_party/re2/re2/testing/exhaustive2_test.cc b/third_party/re2/re2/testing/exhaustive2_test.cc

index c5fec5b3e4a884b03a5717653864499fa7730bb2..6dc50166a6896eca05b4b4343675191560c00535 100644

--- a/third_party/re2/re2/testing/exhaustive2_test.cc

+++ b/third_party/re2/re2/testing/exhaustive2_test.cc

@@ -23,7 +23,7 @@ TEST(EmptyString, Exhaustive) {

TEST(Punctuation, Literals) {

vector<string> alphabet = Explode("()*+?{}[]\\^$.");

vector<string> escaped = alphabet;

- for (int i = 0; i < escaped.size(); i++)

+ for (size_t i = 0; i < escaped.size(); i++)

escaped[i] = "\\" + escaped[i];

ExhaustiveTest(1, 1, escaped, RegexpGenerator::EgrepOps(),

2, alphabet, "", "");