third_party/re2/re2/testing/dump.cc - Issue 1516543002: Update re2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/re2/re2/testing/dump.cc

Issue 1516543002: Update re2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated update instructions Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/re2/re2/testing/dump.cc

diff --git a/third_party/re2/re2/testing/dump.cc b/third_party/re2/re2/testing/dump.cc

index 4bdf71465e2242dd4043099e276dad0d03b79af8..97030390df5e3396b52d7450e0ddbf16e99e715f 100644

--- a/third_party/re2/re2/testing/dump.cc

+++ b/third_party/re2/re2/testing/dump.cc

@@ -120,6 +120,8 @@ static void DumpRegexpAppending(Regexp* re, string* s) {

DumpRegexpAppending(re->sub()[0], s);

break;

case kRegexpCapture:

+ if (re->cap() == 0)

+ LOG(DFATAL) << "kRegexpCapture cap() == 0";

if (re->name()) {

s->append(*re->name());

s->append(":");