third_party/re2/README.chromium - Issue 1516543002: Update re2

Side by Side Diff: third_party/re2/README.chromium

Issue 1516543002: Update re2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove sparse-array-valgrind.patch Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 Name: re2 - an efficient, principled regular expression library	1 Name: re2 - an efficient, principled regular expression library

2 Short Name: re2	2 Short Name: re2

3 URL: https://github.com/google/re2	3 URL: https://github.com/google/re2

4 Version: 7f91923f3ad4	4 Version: dba3349aba83b5588e85e5ecf2b56c97f2d259b7

5 Date: 2012-06-20	5 Date: 2015-12-10

6 Revision: 100:7f91923f3ad4

7 License: BSD 3-Clause	6 License: BSD 3-Clause

8 License File: LICENSE	7 License File: LICENSE

9 Security Critical: yes	8 Security Critical: yes

10	9

11 Description:	10 Description:

12 RE2 is a fast, safe, thread-friendly alternative to backtracking regular	11 RE2 is a fast, safe, thread-friendly alternative to backtracking regular

13 expression engines like those used in PCRE, Perl, and Python.	12 expression engines like those used in PCRE, Perl, and Python.

14

15 Local Modifications (to be applied in this order):

16 - Remove valgrind specific code that exists in chromium already

17 (patches/remove-valgrind-code.patch)
tfarina 2015/12/12 13:01:24 base/third_party/dynamic_annotations/dynamic_annot base/third_party/dynamic_annotations/dynamic_annotations.h include in util/util.h isn't necessary anymore? battre 2015/12/12 13:45:05 All uses of ANNOTATE_ macros have been removed ups Show quoted text On 2015/12/12 13:01:24, tfarina wrote: > base/third_party/dynamic_annotations/dynamic_annotations.h include in > util/util.h isn't necessary anymore? All uses of ANNOTATE_ macros have been removed upstream.
18 - Support for Windows (patches/re2-msvc9-chrome.patch)

19 - Support Android (patches/re2-android.patch)
tfarina 2015/12/12 13:01:24 OS_ANDROID isn't necessary in util/util.h anymore? OS_ANDROID isn't necessary in util/util.h anymore? battre 2015/12/12 13:45:05 I fully relied on the trybots here that were happy Show quoted text On 2015/12/12 13:01:24, tfarina wrote: > OS_ANDROID isn't necessary in util/util.h anymore? I fully relied on the trybots here that were happy with dropping this.
20 - Remove static initializers (patches/remove-static-initializers.patch)

21 - Support libcxx (patches/re2-libcxx.patch)
tfarina 2015/12/12 13:01:24 isn't this necessary now because Android moved fro isn't this necessary now because Android moved from stlport? battre 2015/12/12 13:45:05 See above. I relied on the trybots. Show quoted text On 2015/12/12 13:01:24, tfarina wrote: > isn't this necessary now because Android moved from stlport? See above. I relied on the trybots.
22 https://code.google.com/p/re2/issues/detail?id=76

23 - Memory optimization for filtered trees

24 (patches/re2-memory-optimization.patch)

25 - Prevent unwanted reports from MemorySanitizer. Note: there's an upstream fix

26 for this (https://code.google.com/p/re2/issues/detail?id=77) which is rendered

27 ineffective by patches/remove-valgrind-code.patch

28 (patches/re2-msan.patch)

29 - Remove comparisons of this with NULL, merges upstream b92ce81f1e25

30 - Let COMPILE_ASSERT use static_assert if available, merges upstream

31 2225f94df8ec

32 - Merge upstream cc56ba02d9d2bdafa614ad5ebf564dde287625bb.

33 - Suppress more unwanted reports from MemorySanitizer.

34 (patches/sparse-array-valgrind.patch)
tfarina 2015/12/12 13:01:24 was this upstreamed? really? reilly just did https was this upstreamed? really? reilly just did https://chromium.googlesource.com/chromium/src.git/+/7e7706ee201acbd7e4784fbd... two days ago. battre 2015/12/12 13:45:05 This is really's patch in Chrome: https://coderevi Show quoted text On 2015/12/12 13:01:24, tfarina wrote: > was this upstreamed? really? reilly just did > https://chromium.googlesource.com/chromium/src.git/+/7e7706ee201acbd7e4784fbd... > two days ago. This is really's patch in Chrome: https://codereview.chromium.org/1509953005/diff/1/third_party/re2/util/sparse... And this has landed upstream recently and is included in this patch: https://codereview.chromium.org/1516543002/diff2/1:100001/third_party/re2/uti... See https://github.com/google/re2/commit/dba3349aba83b5588e85e5ecf2b56c97f2d259b7 My understanding was that this should address really's concerns.
OLD	NEW

« no previous file with comments | « third_party/re2/README ('k') | third_party/re2/WORKSPACE » ('j') | no next file with comments »