runtime/vm/flow_graph_inliner.cc - Issue 151653002: Fix wrongly recorded uses after polymorphic inlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 151653002: Fix wrongly recorded uses after polymorphic inlining. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_inliner.cc

===================================================================

--- runtime/vm/flow_graph_inliner.cc (revision 32194)

+++ runtime/vm/flow_graph_inliner.cc (working copy)

@@ -1011,6 +1011,10 @@

// Convert the old target entry to a new join entry.

TargetEntryInstr* old_target =

inlined_entries_[i]->AsGraphEntry()->normal_entry();

+ // Unuse all inputs in the the old graph entry since it is not part of

+ // the graph anymore. A new target be created instead.

srdjan 2014/02/01 00:47:36 Fix last sentence in the comment.

Florian Schneider 2014/02/03 09:47:42 Oops. Will fix this my next CL.

+ inlined_entries_[i]->AsGraphEntry()->UnuseAllInputs();

JoinEntryInstr* new_join = BranchSimplifier::ToJoinEntry(old_target);

old_target->ReplaceAsPredecessorWith(new_join);

for (intptr_t j = 0; j < old_target->dominated_blocks().length(); ++j) {

« no previous file with comments | « pkg/pkgbuild.status ('k') | no next file » | no next file with comments »