Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1516493002: VM: Add missing source line info in await-for statements. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Add missing source line info in await-for statements. When an exception occurs in the constructor of the steam iterator, the stack trace was missing the source position. BUG=#24084 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/12155b1920b19c0f6d743a841cbe3c36145f6046

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M runtime/vm/parser.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
5 years ago (2015-12-09 12:57:39 UTC) #3
rmacnak
lgtm
5 years ago (2015-12-10 17:20:14 UTC) #4
Florian Schneider
5 years ago (2015-12-10 17:58:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
12155b1920b19c0f6d743a841cbe3c36145f6046 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698