Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1516483002: Remove deprecated APIs from test-api.cc, lines 10k - 17k. (Closed)

Created:
5 years ago by vogelheim
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove deprecated APIs from test-api.cc, lines 10k - 17k. - Except 2x applications of ForceSet, where I still need to debug why the expected replacement doesn't work as expected. - Ca. 3/4 of the file is covered. R=jochen@chromium.org BUG= Committed: https://crrev.com/35452afafbb2da49b9c6f946f42e1ef2b735bf03 Cr-Commit-Position: refs/heads/master@{#32714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -409 lines) Patch
M test/cctest/test-api.cc View 114 chunks +753 lines, -409 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vogelheim
5 years ago (2015-12-09 12:53:51 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-09 12:56:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516483002/1
5 years ago (2015-12-09 13:00:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 13:18:10 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-09 13:18:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35452afafbb2da49b9c6f946f42e1ef2b735bf03
Cr-Commit-Position: refs/heads/master@{#32714}

Powered by Google App Engine
This is Rietveld 408576698