Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1516433004: Componentize SyncBackendHostImpl unittest (Closed)

Created:
5 years ago by blundell
Modified:
5 years ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize SyncBackendHostImpl unittest This CL cleans the SyncBackendHostImpl unittest of //content and //chrome dependencies and moves it into its proper location next to the production code that it is testing. BUG=544975 Committed: https://crrev.com/136e27f806e6788a046e60076c41972d37e3485b Cr-Commit-Position: refs/heads/master@{#364462}

Patch Set 1 #

Patch Set 2 : Self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -911 lines) Patch
D chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 chunk +0 lines, -866 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A + components/sync_driver/glue/sync_backend_host_impl_unittest.cc View 1 11 chunks +34 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
blundell
5 years ago (2015-12-10 16:40:57 UTC) #2
Nicolas Zea
lgtm
5 years ago (2015-12-10 19:34:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516433004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516433004/20001
5 years ago (2015-12-10 20:27:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 20:40:37 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 20:41:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/136e27f806e6788a046e60076c41972d37e3485b
Cr-Commit-Position: refs/heads/master@{#364462}

Powered by Google App Engine
This is Rietveld 408576698