Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1516433003: Roll Clang 254793:255169 (Closed)

Created:
5 years ago by hans
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Clang 254793:255169 This is a small roll, picking up r255169 which fixes the CFI build. BUG=568248 Committed: https://crrev.com/c4957160ca593467f9ec35001c3c35bb6bccca61 Cr-Commit-Position: refs/heads/master@{#364360}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M build/common.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
hans
Please take a look, and feel free to CQ if it looks good when you ...
5 years ago (2015-12-10 03:31:56 UTC) #3
Nico
lgtm
5 years ago (2015-12-10 03:34:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516433003/1
5 years ago (2015-12-10 03:35:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/153272)
5 years ago (2015-12-10 03:41:17 UTC) #8
hans
Hmm, tryjobs don't look entirely great.. Most look like transient goma problems. But this one ...
5 years ago (2015-12-10 05:16:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516433003/20001
5 years ago (2015-12-10 11:29:40 UTC) #12
Nico
https://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel?numbuilds=200 has many webkit_unit_tests failures recently, not all for this CL. Looks related to resource ...
5 years ago (2015-12-10 14:04:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516433003/20001
5 years ago (2015-12-10 14:55:28 UTC) #16
Nico
I tried local "incremental" builds (which rebuilt all of the c++ sources of course), and ...
5 years ago (2015-12-10 14:56:01 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 14:59:46 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-10 15:01:14 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4957160ca593467f9ec35001c3c35bb6bccca61
Cr-Commit-Position: refs/heads/master@{#364360}

Powered by Google App Engine
This is Rietveld 408576698