Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1516433002: Sanitize js OWNERS file. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Sanitize js OWNERS file. NOTRY=true R=verwaest@chromium.org Committed: https://crrev.com/109a5e7bf35a6e50d79a333b314e9cf0c91fe1c9 Cr-Commit-Position: refs/heads/master@{#32708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/js/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Benedikt Meurer
5 years ago (2015-12-09 10:38:10 UTC) #1
Benedikt Meurer
Ulan doesn't care about src/js and was quite surprised when I told him that he's ...
5 years ago (2015-12-09 10:39:08 UTC) #2
ulan
lgtm
5 years ago (2015-12-09 10:42:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516433002/1
5 years ago (2015-12-09 10:43:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11208)
5 years ago (2015-12-09 10:57:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516433002/1
5 years ago (2015-12-09 11:32:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 11:34:44 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-09 11:35:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/109a5e7bf35a6e50d79a333b314e9cf0c91fe1c9
Cr-Commit-Position: refs/heads/master@{#32708}

Powered by Google App Engine
This is Rietveld 408576698