Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: pkg/analyzer_cli/test/strong_mode_test.dart

Issue 1516353003: Make `analyzer_cli` tests bot-friendly (#25001). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_cli/test/sdk_ext_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/test/strong_mode_test.dart
diff --git a/pkg/analyzer_cli/test/strong_mode_test.dart b/pkg/analyzer_cli/test/strong_mode_test.dart
index 7060fa87858be609a1521eabb4c14f4917774d42..f2c533bf81b514b9002d7eb7ce2667bbcf154e33 100644
--- a/pkg/analyzer_cli/test/strong_mode_test.dart
+++ b/pkg/analyzer_cli/test/strong_mode_test.dart
@@ -21,10 +21,7 @@ import 'utils.dart';
/// Generally we don't want a lot of cases here as it requires spinning up a
/// full analysis context.
///
-// TODO(pq): fix tests to run safely on the bots
-// https://github.com/dart-lang/sdk/issues/25001
-main() {}
-not_main() {
+main() {
group('--strong', () {
StringSink savedOutSink, savedErrorSink;
int savedExitCode;
@@ -42,8 +39,7 @@ not_main() {
});
test('produces stricter errors', () async {
- var testPath = path.join(testDirectory, 'data/strong_example.dart');
- new Driver().start(['--options', emptyOptionsFile, '--strong', testPath]);
+ drive('data/strong_example.dart', args: ['--strong']);
expect(exitCode, 3);
var stdout = outSink.toString();
« no previous file with comments | « pkg/analyzer_cli/test/sdk_ext_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698