Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Issue 1516353003: Make `analyzer_cli` tests bot-friendly (#25001). (Closed)

Created:
5 years ago by pquitslund
Modified:
5 years ago
Reviewers:
keertip
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make `analyzer_cli` tests bot-friendly (#25001). * re-enables a host of tests that were breaking on the bots due to path issues Bug: https://github.com/dart-lang/sdk/issues/25001 R=keertip@google.com Committed: https://github.com/dart-lang/sdk/commit/e67affe6b6e35f7ed933c1736b60dc10bf164652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -96 lines) Patch
M pkg/analyzer_cli/test/all.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 11 chunks +53 lines, -78 lines 0 comments Download
M pkg/analyzer_cli/test/sdk_ext_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analyzer_cli/test/strong_mode_test.dart View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
5 years ago (2015-12-11 22:06:51 UTC) #2
keertip
lgtm
5 years ago (2015-12-11 22:13:16 UTC) #3
pquitslund
5 years ago (2015-12-11 22:13:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e67affe6b6e35f7ed933c1736b60dc10bf164652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698