Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1516303002: Adds support for POST request with bodies on WKWebView. (Closed)

Created:
5 years ago by lpromero
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Adds support for POST request with bodies on WKWebView. These requests are now handled through a javascript hack to work around this webkit bug: https://bugs.webkit.org/show_bug.cgi?id=145410. BUG=489692 Review URL: https://codereview.chromium.org/1375023002 Cr-Commit-Position: refs/heads/master@{#363256} (cherry picked from commit 8d13d52f53c03f6b78ab8fbf7148155780063244) Committed: https://chromium.googlesource.com/chromium/src/+/b35e6bfd6a0ed765ab02746c7fa5978a3009e01c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -9 lines) Patch
M ios/web/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/web/ios_web_unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ios/web/web_state/js/crw_js_post_request_loader.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/web/web_state/js/crw_js_post_request_loader.mm View 1 chunk +156 lines, -0 lines 0 comments Download
A ios/web/web_state/js/crw_js_post_request_loader_unittest.mm View 1 chunk +105 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/post_request.js View 1 chunk +84 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router.mm View 1 chunk +5 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 8 chunks +61 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lpromero
5 years ago (2015-12-11 12:49:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b35e6bfd6a0ed765ab02746c7fa5978a3009e01c.

Powered by Google App Engine
This is Rietveld 408576698