Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/browser/resources/ntp4/incognito_and_guest_tab.css

Issue 1516233003: Incognito NTP style tweaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits. Fix button padding. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ntp4/incognito_and_guest_tab.css
diff --git a/chrome/browser/resources/ntp4/incognito_and_guest_tab.css b/chrome/browser/resources/ntp4/incognito_and_guest_tab.css
index fb398dd94f87ed085d516f90e40f767f1f43eb67..38049f65ee750d676ccb33d53483b4dd515c55cc 100644
--- a/chrome/browser/resources/ntp4/incognito_and_guest_tab.css
+++ b/chrome/browser/resources/ntp4/incognito_and_guest_tab.css
@@ -7,12 +7,12 @@
h1 {
font-size: 200%;
- font-weight: normal;
- margin-bottom: 1.33em;
Evan Stade 2015/12/14 20:27:22 why change this
edwardjung 2015/12/15 11:30:39 It rounds up the margin to 32px rather than 31.920
Evan Stade 2015/12/15 19:25:14 why is 0.08px important?
edwardjung 2015/12/17 13:32:57 In this instance I guess it doesn't matter as it's
+ font-weight: 300;
+ margin-bottom: 1.33333em;
}
p {
- line-height: 1.7;
+ line-height: 1.5;
margin-bottom: 2em;
text-align: start;
}
@@ -30,9 +30,9 @@ a:hover {
.content {
box-sizing: border-box;
margin: 3.5em auto 0;
+ max-width: 420px;
padding: 30px 35px;
text-align: center;
- width: 420px;
Evan Stade 2015/12/14 20:27:22 I don't think you should change this. - Horizonta
edwardjung 2015/12/15 11:30:39 Agree that when it's really narrow it doesn't look
Evan Stade 2015/12/15 19:25:13 that is up to the window manager you're using and
edwardjung 2015/12/17 13:32:57 Understood they all vary and did some tweaks to ma
}
html[hascustombackground='true'] .content {

Powered by Google App Engine
This is Rietveld 408576698