Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 15162003: Fix heapchecker shared_library build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 06e9b3b703da8db50d006f45273553d3d8e193e2..d3b0b279c29e8e11243a1f4884d9d6a61333f65a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3237,6 +3237,13 @@
['linux_use_heapchecker==1', {
'variables': {'linux_use_tcmalloc%': 1},
'defines': ['USE_HEAPCHECKER'],
+ 'conditions': [
+ ['component=="shared_library"', {
+ # See crbug.com/112389
+ # TODO(glider): replace with --dynamic-list or something
+ 'ldflags': ['-rdynamic'],
+ }],
+ ],
}],
['linux_use_tcmalloc==0', {
'defines': ['NO_TCMALLOC'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698