Issue 15162002: Avoid convertion to double when it is not needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15162002: Avoid convertion to double when it is not needed. (Closed)

Created:
7 years, 7 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 7 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Avoid convertion to double when it is not needed. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14664

Patch Set 2 : CR feedback #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	src/factory.h	View	1	2 chunks	+15 lines, -1 line	0 comments	Download
	M	src/runtime.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

This turned out to be about 10% of initialization

7 years, 7 months ago (2013-05-14 11:58:48 UTC) #1

rossberg

https://codereview.chromium.org/15162002/diff/3/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/15162002/diff/3/src/runtime.cc#newcode860 src/runtime.cc:860: if (Smi::IsValid(static_cast<intptr_t>(length))) { I think this should be refactored ...

7 years, 7 months ago (2013-05-14 14:00:45 UTC) #2

Dmitry Lomov (no reviews)

7 years, 7 months ago (2013-05-14 15:03:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r14664 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15162002: Avoid convertion to double when it is not needed. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : CR feedback #

Messages