filter/dscache/support.go - Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: filter/dscache/support.go

Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct. (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: remove accidental extra test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: filter/dscache/support.go

diff --git a/filter/dscache/support.go b/filter/dscache/support.go

index ea64460886d971efa1272e9e7072d08e3058f60c..4a2480ab7d29162ff37510758d453a2767109e2c 100644

--- a/filter/dscache/support.go

+++ b/filter/dscache/support.go

@@ -42,7 +42,8 @@ func (s *supportContext) numShards(k *ds.Key) int {

func (s *supportContext) mkRandKeys(keys []*ds.Key, metas ds.MultiMetaGetter) []string {

ret := []string(nil)

for i, key := range keys {

- if !metas.GetMetaDefault(i, CacheEnableMeta, true).(bool) {

+ mg := metas.GetSingle(i)

+ if !ds.GetMetaDefault(mg, CacheEnableMeta, true).(bool) {

continue

}

shards := s.numShards(key)