Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: service/datastore/raw_interface_test.go

Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: remove accidental extra test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« service/datastore/pls.go ('K') | « service/datastore/raw_interface.go ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package datastore 5 package datastore
6 6
7 import ( 7 import (
8 "testing" 8 "testing"
9 9
10 . "github.com/smartystreets/goconvey/convey" 10 . "github.com/smartystreets/goconvey/convey"
11 ) 11 )
12 12
13 func TestMultiMetaGetter(t *testing.T) { 13 func TestMultiMetaGetter(t *testing.T) {
14 t.Parallel() 14 t.Parallel()
15 15
16 Convey("Test MultiMetaGetter", t, func() { 16 Convey("Test MultiMetaGetter", t, func() {
17 Convey("nil", func() { 17 Convey("nil", func() {
18 mmg := NewMultiMetaGetter(nil) 18 mmg := NewMultiMetaGetter(nil)
19 » » » val, err := mmg.GetMeta(7, "hi") 19 » » » val, ok := mmg.GetMeta(7, "hi")
20 » » » So(err, ShouldEqual, ErrMetaFieldUnset) 20 » » » So(ok, ShouldBeFalse)
21 So(val, ShouldBeNil) 21 So(val, ShouldBeNil)
22 22
23 » » » So(mmg.GetMetaDefault(7, "hi", "value"), ShouldEqual, "v alue") 23 » » » So(GetMetaDefault(mmg.GetSingle(7), "hi", "value"), Shou ldEqual, "value")
24 24
25 m := mmg.GetSingle(10) 25 m := mmg.GetSingle(10)
26 » » » val, err = m.GetMeta("hi") 26 » » » val, ok = m.GetMeta("hi")
27 » » » So(err, ShouldEqual, ErrMetaFieldUnset) 27 » » » So(ok, ShouldBeFalse)
28 So(val, ShouldBeNil) 28 So(val, ShouldBeNil)
29 » » » So(m.GetMetaDefault("hi", "value"), ShouldEqual, "value" ) 29
30 » » » So(GetMetaDefault(m, "hi", "value"), ShouldEqual, "value ")
30 }) 31 })
31 32
32 Convey("stuff", func() { 33 Convey("stuff", func() {
33 pmaps := []PropertyMap{{}, nil, {}} 34 pmaps := []PropertyMap{{}, nil, {}}
34 » » » So(pmaps[0].SetMeta("hi", "thing"), ShouldBeNil) 35 » » » So(pmaps[0].SetMeta("hi", "thing"), ShouldBeTrue)
35 » » » So(pmaps[2].SetMeta("key", 100), ShouldBeNil) 36 » » » So(pmaps[2].SetMeta("key", 100), ShouldBeTrue)
36 mmg := NewMultiMetaGetter(pmaps) 37 mmg := NewMultiMetaGetter(pmaps)
37 38
38 // oob is OK 39 // oob is OK
39 » » » So(mmg.GetMetaDefault(7, "hi", "value"), ShouldEqual, "v alue") 40 » » » So(GetMetaDefault(mmg.GetSingle(7), "hi", "value"), Shou ldEqual, "value")
40 41
41 // nil is OK 42 // nil is OK
42 » » » So(mmg.GetMetaDefault(1, "key", true), ShouldEqual, true ) 43 » » » So(GetMetaDefault(mmg.GetSingle(1), "key", true), Should Equal, true)
43 44
44 » » » val, err := mmg.GetMeta(0, "hi") 45 » » » val, ok := mmg.GetMeta(0, "hi")
45 » » » So(err, ShouldBeNil) 46 » » » So(ok, ShouldBeTrue)
46 So(val, ShouldEqual, "thing") 47 So(val, ShouldEqual, "thing")
47 48
48 » » » So(mmg.GetMetaDefault(2, "key", 20), ShouldEqual, 100) 49 » » » So(GetMetaDefault(mmg.GetSingle(2), "key", 20), ShouldEq ual, 100)
49 }) 50 })
50 }) 51 })
51 } 52 }
OLDNEW
« service/datastore/pls.go ('K') | « service/datastore/raw_interface.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698