Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1516073003: Revert of Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. (Closed)

Created:
5 years ago by Marijn Kruisselbrink
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. (patchset #8 id:130001 of https://codereview.chromium.org/1513283003/ ) Reason for revert: This is causing cc_unittests failures on the main waterfall: https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/62640/steps/cc_unittests%20on%20Windows-Vista-SP2 and https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/16225/steps/cc_unittests%20on%20Mac-10.9 Original issue's description: > Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. > > This will cause Skia to do more accurate allocations for offscreen > buffers, reducing memory usage. > > Mark affected tests as needing rebaseline, or give new reference result. > > BUG=240827 > R=fmalita@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/d42be13c51bbc3969f2b3b9f9e1c6f0abf236a3e TBR=fmalita@chromium.org,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=240827 Committed: https://crrev.com/f1b254bbe7c042cb3711dd83e41afb93484b6b42 Cr-Commit-Position: refs/heads/master@{#364520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/feoffset-region-zoom-expected.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Marijn Kruisselbrink
Created Revert of Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef.
5 years ago (2015-12-10 23:20:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516073003/1
5 years ago (2015-12-10 23:21:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 23:25:22 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-10 23:26:13 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1b254bbe7c042cb3711dd83e41afb93484b6b42
Cr-Commit-Position: refs/heads/master@{#364520}

Powered by Google App Engine
This is Rietveld 408576698