Add some missing encodings in the ARM integrated assembler.

Add some missing encodings in the ARM integrated assembler.

Adds the data-processing "register-shifted register" form, as
well as the 5-bit immediate shift for mov instructions (which
unfortunately represent this form differently than other instructions).

This CL fixes the ARM integrated assembler to handle all non-V
(i.e. neon) instructions used by the spec2k test suite except:

   rsc: 59 instances.
   rev: 14 instances.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=662d4eba13941af0219b7012f31cbb53abf178c9

[Karl, 2015-12-10 21:39:44]

Description was changed from

==========
Add some missing encodings in the ARM integrated assembler.

Adds the data-processing "register-shifted register" form, as
well as the 5-bit immediate shift for mov instructions (which
unfortunately represent this form differently than other instructions).

This CL fixes the ARM integrated assembler to handle all non-V
(i.e. neon) instruction used by the spec2k test suite except:

   rsc: 59 instances.
   rev: 14 instances.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add some missing encodings in the ARM integrated assembler.

Adds the data-processing "register-shifted register" form, as
well as the 5-bit immediate shift for mov instructions (which
unfortunately represent this form differently than other instructions).

This CL fixes the ARM integrated assembler to handle all non-V
(i.e. neon) instructions used by the spec2k test suite except:

   rsc: 59 instances.
   rev: 14 instances.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-12-10 21:49:01]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[John, 2015-12-11 16:40:57]

lgtm

https://codereview.chromium.org/1516063002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1516063002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:273: int32_t Val = IntConst->getValue();
is this code path still exercised? it shouldn't be. if it is, let me know and I
will fix the lowering.

[Jim Stichnoth, 2015-12-11 16:53:45]

lgtm

https://codereview.chromium.org/1516063002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/mov-reg.ll (right):

https://codereview.chromium.org/1516063002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/mov-reg.ll:24: define internal i64
@_Z4castIaxET0_T_(i32 %a) {
Friendlier function name?

[Karl, 2015-12-11 17:41:58]

Description was changed from

==========
Add some missing encodings in the ARM integrated assembler.

Adds the data-processing "register-shifted register" form, as
well as the 5-bit immediate shift for mov instructions (which
unfortunately represent this form differently than other instructions).

This CL fixes the ARM integrated assembler to handle all non-V
(i.e. neon) instructions used by the spec2k test suite except:

   rsc: 59 instances.
   rev: 14 instances.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add some missing encodings in the ARM integrated assembler.

Adds the data-processing "register-shifted register" form, as
well as the 5-bit immediate shift for mov instructions (which
unfortunately represent this form differently than other instructions).

This CL fixes the ARM integrated assembler to handle all non-V
(i.e. neon) instructions used by the spec2k test suite except:

   rsc: 59 instances.
   rev: 14 instances.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2015-12-11 17:41:59]

Committed patchset #3 (id:40001) manually as
662d4eba13941af0219b7012f31cbb53abf178c9 (presubmit successful).

[Karl, 2015-12-11 17:42:16]

https://codereview.chromium.org/1516063002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1516063002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:273: int32_t Val = IntConst->getValue();
On 2015/12/11 16:40:57, John wrote:
> is this code path still exercised? it shouldn't be. if it is, let me know and
I
> will fix the lowering.

Look at tests_lit/assembler/arm32/mov-reg.ll. If you comment out this "else if"
and then run "make -f Makefile.standalone check-lit", you will see the case.

https://codereview.chromium.org/1516063002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/mov-reg.ll (right):

https://codereview.chromium.org/1516063002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/mov-reg.ll:24: define internal i64
@_Z4castIaxET0_T_(i32 %a) {
On 2015/12/11 16:53:45, stichnot wrote:
> Friendlier function name?

Done.