Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 151603005: android envsetup: Move some webview-specific configuration into gyp_webview. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, android-webview-reviews_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

android envsetup: Move some webview-specific configuration into gyp_webview. Engineers working on webview always call gyp_webview instead of gyp_chromium, so there's no need to keep these settings in env vars. BUG=330631 R=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248723

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M android_webview/tools/gyp_webview View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M build/android/envsetup.sh View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/envsetup_functions.sh View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
6 years, 10 months ago (2014-02-03 19:03:57 UTC) #1
Torne
lgtm
6 years, 10 months ago (2014-02-04 10:16:08 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 10 months ago (2014-02-04 14:21:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/151603005/70001
6 years, 10 months ago (2014-02-04 14:21:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 14:58:44 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223192
6 years, 10 months ago (2014-02-04 14:58:44 UTC) #6
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 14:58:45 UTC) #7
Nico
6 years, 10 months ago (2014-02-04 15:26:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r248723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698