Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Issue 1516013002: Revert of mash: Add a couple of apptests for AcceleratorRegistrar. (Closed)

Created:
5 years ago by Marijn Kruisselbrink
Modified:
5 years ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mash: Add a couple of apptests for AcceleratorRegistrar. (patchset #2 id:20001 of https://codereview.chromium.org/1510713002/ ) Reason for revert: AcceleratorRegistrarTest.AcceleratorsRemovedOnHandlerDestroy is flaky on both trybots and the main waterfall (see https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/35418 for one random example where it failed). BUG=568634 Original issue's description: > mash: Add a couple of apptests for AcceleratorRegistrar. > > . Test that different AcceleratorRegistrars get different namespaces, and so can > install accelerators with the same id. > . Test that differentl registrars do not allow registering accelerators with the > same event matcher. > . Test that destroying an AcceleratorHandler removes associated accelerators. > > BUG=548363 > > Committed: https://crrev.com/8aac81dc92c8eaaec476b0c6c5ccf3e114590b68 > Cr-Commit-Position: refs/heads/master@{#363719} TBR=ben@chromium.org,sadrul@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=548363 Committed: https://crrev.com/0c84dc769b19597974bb6cc881fcb6aa42b67e4d Cr-Commit-Position: refs/heads/master@{#364450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -144 lines) Patch
M mash/wm/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mash/wm/accelerator_registrar_apptest.cc View 1 chunk +0 lines, -143 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Marijn Kruisselbrink
Created Revert of mash: Add a couple of apptests for AcceleratorRegistrar.
5 years ago (2015-12-10 19:58:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516013002/1
5 years ago (2015-12-10 20:04:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 20:11:32 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-10 20:13:24 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c84dc769b19597974bb6cc881fcb6aa42b67e4d
Cr-Commit-Position: refs/heads/master@{#364450}

Powered by Google App Engine
This is Rietveld 408576698