Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1516003002: Remove bogus "public:" in SharedFunctionInfo. (Closed)

Created:
5 years ago by mvstanton
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove bogus "public:" in SharedFunctionInfo. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/412d4f1a8c97311ddb1914b1e2db917c799d82f1 Cr-Commit-Position: refs/heads/master@{#32939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Sigh. When I rush, I mistakes make. :p --Mike
5 years ago (2015-12-10 18:08:17 UTC) #1
Michael Starzinger
LGTM.
5 years ago (2015-12-10 18:42:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516003002/1
5 years ago (2015-12-17 10:52:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 11:30:13 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-17 11:31:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/412d4f1a8c97311ddb1914b1e2db917c799d82f1
Cr-Commit-Position: refs/heads/master@{#32939}

Powered by Google App Engine
This is Rietveld 408576698