Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1515963003: Revert of Label non-capturing groups if no capturing needed (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, tfarina, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Label non-capturing groups if no capturing needed (patchset #1 id:1 of https://codereview.chromium.org/1515553005/ ) Reason for revert: It does not solve the memory perf regression. Will also revert the other CL. Original issue's description: > Label non-capturing groups if no capturing needed > > Without this patch, a new version of RE2 (not checked in, yet) runs out of memory: > ../../third_party/re2/re2/dfa.cc:469: DFA out of memory: prog size 17637 mem 2725434 > > BUG=568564, 568134 > > Committed: https://crrev.com/dd739e8bd477dd6c45e64630320adfd99ca54d4c > Cr-Commit-Position: refs/heads/master@{#364354} TBR=vabr@google.com,vabr@chromium.org,battre@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=568564, 568134 Committed: https://crrev.com/da335781989562c116ec60c109f6f6470ee02c30 Cr-Commit-Position: refs/heads/master@{#364405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M components/autofill/core/browser/autofill_regex_constants.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M components/autofill/core/browser/form_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
Created Revert of Label non-capturing groups if no capturing needed
5 years ago (2015-12-10 18:27:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963003/1
5 years ago (2015-12-10 18:28:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 18:31:08 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-10 18:31:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da335781989562c116ec60c109f6f6470ee02c30
Cr-Commit-Position: refs/heads/master@{#364405}

Powered by Google App Engine
This is Rietveld 408576698