Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: content/browser/frame_host/debug_urls.cc

Issue 151593004: Fix bugs with renderer-side debug URLs, like chrome://crash or javascript:. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/debug_urls.h" 5 #include "content/browser/frame_host/debug_urls.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "content/browser/gpu/gpu_process_host_ui_shim.h" 10 #include "content/browser/gpu/gpu_process_host_ui_shim.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 if (url == GURL(kChromeUIPpapiFlashCrashURL) || 73 if (url == GURL(kChromeUIPpapiFlashCrashURL) ||
74 url == GURL(kChromeUIPpapiFlashHangURL)) { 74 url == GURL(kChromeUIPpapiFlashHangURL)) {
75 BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, 75 BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
76 base::Bind(&HandlePpapiFlashDebugURL, url)); 76 base::Bind(&HandlePpapiFlashDebugURL, url));
77 return true; 77 return true;
78 } 78 }
79 79
80 return false; 80 return false;
81 } 81 }
82 82
83 bool IsRendererDebugURL(const GURL& url) {
84 if (!url.is_valid())
85 return false;
86
87 if (url.SchemeIs(kJavaScriptScheme))
88 return true;
89
90 return url == GURL(kChromeUICrashURL) ||
91 url == GURL(kChromeUIKillURL) ||
92 url == GURL(kChromeUIHangURL) ||
93 url == GURL(kChromeUIShorthangURL);
nasko 2014/01/31 23:56:07 Shouldn't that list include the rest of the ones p
Charlie Reis 2014/01/31 23:59:22 No, there's a distinction between those 7 (which a
nasko 2014/02/01 00:05:05 Ah, that makes sense. Thanks!
94 }
95
83 } // namespace content 96 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698