Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 151593002: Add GPU bots to the default set of try jobs in ui/gl/ and gpu/. (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org, bajones, piman, no sievers
Visibility:
Public.

Description

Add GPU bots to the default set of try jobs in ui/gl/ and gpu/. R=kbr@chromium.org, piman@chromium.org, piman BUG=270918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248541

Patch Set 1 #

Patch Set 2 : gpubots: #

Total comments: 2

Patch Set 3 : gpubots: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M cc/PRESUBMIT.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/PRESUBMIT.py View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
A + ui/gl/PRESUBMIT.py View 1 2 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
danakj
6 years, 10 months ago (2014-01-31 16:23:37 UTC) #1
Ken Russell (switch to Gerrit)
LGTM -- thanks for taking care of this. https://codereview.chromium.org/151593002/diff/40001/gpu/PRESUBMIT.py File gpu/PRESUBMIT.py (right): https://codereview.chromium.org/151593002/diff/40001/gpu/PRESUBMIT.py#newcode13 gpu/PRESUBMIT.py:13: 'win_gpu', ...
6 years, 10 months ago (2014-01-31 16:28:40 UTC) #2
danakj
https://codereview.chromium.org/151593002/diff/40001/gpu/PRESUBMIT.py File gpu/PRESUBMIT.py (right): https://codereview.chromium.org/151593002/diff/40001/gpu/PRESUBMIT.py#newcode13 gpu/PRESUBMIT.py:13: 'win_gpu', On 2014/01/31 16:28:40, Ken Russell (OOO) wrote: > ...
6 years, 10 months ago (2014-01-31 16:31:12 UTC) #3
piman
lgtm
6 years, 10 months ago (2014-02-01 01:08:12 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-03 17:41:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/151593002/90001
6 years, 10 months ago (2014-02-03 17:42:16 UTC) #6
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 10 months ago (2014-02-03 19:05:56 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:05:57 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:06:03 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:06:18 UTC) #10
danakj
6 years, 10 months ago (2014-02-03 19:06:58 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 manually as r248541 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698