Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1515903003: If upload is enabled don't fallback to local save. (Closed)

Created:
5 years ago by Justin Donnelly
Modified:
5 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, bondd, zkoch1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

If upload is enabled don't fallback to local save. We believe that sometimes offering upload and sometimes offering local save is a confusing user experience. If CVC or address isn't available this time it'll be available eventually. It only has to succeed once. The exception is if the upload details RPC fails. I'm still doing fallback here for the reasons explained in the comment there. BUG=535784 Committed: https://crrev.com/6201c91cf4689c2889b38f87c09269054c9bc886 Cr-Commit-Position: refs/heads/master@{#364469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M components/autofill/core/browser/autofill_manager.cc View 2 chunks +18 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 5 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Justin Donnelly
5 years ago (2015-12-10 19:28:54 UTC) #2
Evan Stade
lgtm
5 years ago (2015-12-10 19:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515903003/1
5 years ago (2015-12-10 19:59:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 20:50:21 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 20:51:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6201c91cf4689c2889b38f87c09269054c9bc886
Cr-Commit-Position: refs/heads/master@{#364469}

Powered by Google App Engine
This is Rietveld 408576698