Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: Source/core/html/HTMLPlugInImageElement.cpp

Issue 15159008: Node::lazyAttach shouldn't lie about being attached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Missing commit Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLPlugInImageElement.cpp
diff --git a/Source/core/html/HTMLPlugInImageElement.cpp b/Source/core/html/HTMLPlugInImageElement.cpp
index b5512f38c906350c74bbff3e22a4261840de4ce2..441921e455a2ab0ee4561e4f39b968cf42eaa5c1 100644
--- a/Source/core/html/HTMLPlugInImageElement.cpp
+++ b/Source/core/html/HTMLPlugInImageElement.cpp
@@ -155,7 +155,9 @@ RenderObject* HTMLPlugInImageElement::createRenderer(RenderArena* arena, RenderS
void HTMLPlugInImageElement::willRecalcStyle(StyleChange)
{
- // FIXME: Why is this necessary? Manual re-attach is almost always wrong.
+ // FIXME: setNeedsWidgetUpdate is used by subclasses to signal that they need
+ // their renderer replaced on the next style recalc. It's not clear why they
+ // don't just do lazyReattach instead. This code looks like a terrible hack.
if (!useFallbackContent() && needsWidgetUpdate() && renderer() && !isImageType())
reattach();
}

Powered by Google App Engine
This is Rietveld 408576698