Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 15159004: Band-aid for subsetted bitmaps in SKPs. (Closed)

Created:
7 years, 7 months ago by scroggo
Modified:
7 years, 7 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Band-aid for subsetted bitmaps in SKPs. Partial fix for https://code.google.com/p/skia/issues/detail?id=1301. Instead of firing an assert when the recorded width and height do not match the encoded data's width and height, take a subset of the bitmap of the correct size. The bitmap may be drawn incorrectly, since it will not necessarily be the correct subset (though it will be the correct size). The complete fix will be to record the offset to the stream. Holding off on that since it will change the PICTURE_VERSION. There is still more work to do on read/writeBitmap, and I would like to change PICTURE_VERSION as few times as possible. BUG=https://code.google.com/p/skia/issues/detail?id=1301 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=9169

Patch Set 1 #

Patch Set 2 : Extra comment for clarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M src/core/SkOrderedReadBuffer.cpp View 1 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
7 years, 7 months ago (2013-05-16 19:30:02 UTC) #1
djsollen
lgtm
7 years, 7 months ago (2013-05-16 19:35:06 UTC) #2
scroggo
7 years, 7 months ago (2013-05-16 19:35:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r9169 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698