 Chromium Code Reviews
 Chromium Code Reviews Issue 1515833004:
  Add missing data_deps to webkit_unit_tests  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1515833004:
  Add missing data_deps to webkit_unit_tests  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. | 
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be | 
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. | 
| 4 | 4 | 
| 5 import("//build/config/ui.gni") | 5 import("//build/config/ui.gni") | 
| 6 import("//testing/test.gni") | 6 import("//testing/test.gni") | 
| 7 import("//third_party/WebKit/Source/bindings/bindings.gni") | 7 import("//third_party/WebKit/Source/bindings/bindings.gni") | 
| 8 import("//third_party/WebKit/Source/config.gni") | 8 import("//third_party/WebKit/Source/config.gni") | 
| 9 import("//third_party/WebKit/Source/core/core.gni") | 9 import("//third_party/WebKit/Source/core/core.gni") | 
| 10 import("//third_party/WebKit/Source/modules/modules.gni") | 10 import("//third_party/WebKit/Source/modules/modules.gni") | 
| (...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 122 "//testing/gtest", | 122 "//testing/gtest", | 
| 123 "//third_party/WebKit/Source/platform:test_support", | 123 "//third_party/WebKit/Source/platform:test_support", | 
| 124 "//third_party/WebKit/Source/wtf", | 124 "//third_party/WebKit/Source/wtf", | 
| 125 "//third_party/WebKit/Source/wtf:test_support", | 125 "//third_party/WebKit/Source/wtf:test_support", | 
| 126 "//third_party/libwebp", | 126 "//third_party/libwebp", | 
| 127 "//third_party/zlib", | 127 "//third_party/zlib", | 
| 128 "//url", | 128 "//url", | 
| 129 "//v8", | 129 "//v8", | 
| 130 ] | 130 ] | 
| 131 | 131 | 
| 132 data_deps = [ | |
| 133 "//content/shell:pak", | |
| 
engedy
2015/12/10 13:54:33
Shouldn't this somehow include the test data that
 
tzik
2015/12/10 14:00:08
Added. Yes, it's likely needed.
 | |
| 134 ] | |
| 135 | |
| 132 sources = [ | 136 sources = [ | 
| 133 "tests/RunAllTests.cpp", | 137 "tests/RunAllTests.cpp", | 
| 134 ] | 138 ] | 
| 135 | 139 | 
| 136 configs += [ "//third_party/WebKit/Source:config" ] | 140 configs += [ "//third_party/WebKit/Source:config" ] | 
| 137 | 141 | 
| 138 if (!is_component_build) { | 142 if (!is_component_build) { | 
| 139 deps += [ "//third_party/WebKit/Source/core" ] | 143 deps += [ "//third_party/WebKit/Source/core" ] | 
| 140 | 144 | 
| 141 configs += [ "//third_party/WebKit/Source:inside_blink" ] | 145 configs += [ "//third_party/WebKit/Source:inside_blink" ] | 
| 142 | 146 | 
| 143 sources += web_unittest_files | 147 sources += web_unittest_files | 
| 144 sources += bindings_unittest_files | 148 sources += bindings_unittest_files | 
| 145 sources += core_unittest_files | 149 sources += core_unittest_files | 
| 146 sources += modules_unittest_files | 150 sources += modules_unittest_files | 
| 147 sources += platform_unittest_support_files | 151 sources += platform_unittest_support_files | 
| 148 sources += platform_web_unittest_files | 152 sources += platform_web_unittest_files | 
| 149 } | 153 } | 
| 150 | 154 | 
| 151 if (is_android) { | 155 if (is_android) { | 
| 152 deps += [ | 156 deps += [ | 
| 153 "//base:base_java", | 157 "//base:base_java", | 
| 154 "//content/shell/android:content_shell_assets", | 158 "//content/shell/android:content_shell_assets", | 
| 155 "//net/android:net_java", | 159 "//net/android:net_java", | 
| 156 ] | 160 ] | 
| 157 } | 161 } | 
| 158 } | 162 } | 
| OLD | NEW |