Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1515833003: dart2js: Do not eliminate calls whose receiver can be null. (Closed)

Created:
5 years ago by Kevin Millikin (Google)
Modified:
5 years ago
Reviewers:
asgerf, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Do not eliminate calls whose receiver can be null. In the CPS backend's type propagation, try to avoid eliminating calls whose receiver can be null. This fixes a bug in the constant folding of indexed access. e0[e1] would be folded away if e0 could be null but type inference told us that the elements had a known (specifically null) type. tests/language/inference_list_or_null_test triggers the bug. R=asgerf@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ff1c630edc06edad71cc70d068cce71cccfcb50b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +17 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kevin Millikin (Google)
5 years ago (2015-12-10 11:54:16 UTC) #1
asgerf
LGTM
5 years ago (2015-12-10 11:58:10 UTC) #2
Kevin Millikin (Google)
Committed patchset #1 (id:1) manually as ff1c630edc06edad71cc70d068cce71cccfcb50b (presubmit successful).
5 years ago (2015-12-10 12:02:58 UTC) #4
sra1
5 years ago (2015-12-10 17:03:51 UTC) #6
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698