Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1515823002: Move IceTransport tests to ice_transport_unittest.cc (Closed)

Created:
5 years ago by Sergey Ulanov
Modified:
5 years ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@webrtc_host
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move IceTransport tests to ice_transport_unittest.cc Previously IceTransport was tested as part of jingle_session_unittest.cc. This makes little sense because JingleSession can be used with transports other than IceTransport. Now the tests have been moved to ice_transport_unittest.cc. Committed: https://crrev.com/59cdfa9a030a84c4a79f0488324592a5b7c0614e Cr-Commit-Position: refs/heads/master@{#364793}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -232 lines) Patch
M remoting/protocol/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/protocol/ice_transport_unittest.cc View 1 2 3 1 chunk +362 lines, -0 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 9 chunks +2 lines, -232 lines 0 comments Download
M remoting/remoting_test.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (15 generated)
Sergey Ulanov
5 years ago (2015-12-10 02:12:44 UTC) #2
Jamie
lgtm
5 years ago (2015-12-10 18:45:43 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1506383004 Patch 40001). Please resolve the dependency and ...
5 years ago (2015-12-10 20:09:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515823002/20001
5 years ago (2015-12-10 23:10:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/91167)
5 years ago (2015-12-11 00:36:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515823002/40001
5 years ago (2015-12-11 01:53:44 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/91307)
5 years ago (2015-12-11 03:05:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515823002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515823002/60001
5 years ago (2015-12-11 19:06:07 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-11 20:44:15 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-11 20:44:58 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/59cdfa9a030a84c4a79f0488324592a5b7c0614e
Cr-Commit-Position: refs/heads/master@{#364793}

Powered by Google App Engine
This is Rietveld 408576698