Do not enforce the public API presubmit check for Revert CLs

Do not enforce the public API presubmit check for Revert CLs.

NOTRY=true

BUG=skia:2068
Committed: http://code.google.com/p/skia/source/detail?r=13270

[borenet, 2014-01-31 16:21:57]

LGTM with some reservations.

https://codereview.chromium.org/151573002/diff/70001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/151573002/diff/70001/PRESUBMIT.py#newcode133
PRESUBMIT.py:133: return results
Seems like there should be a more robust way of doing this.  It's a little scary
to depend on the Rietveld format.

[rmistry, 2014-01-31 16:24:00]

https://codereview.chromium.org/151573002/diff/70001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/151573002/diff/70001/PRESUBMIT.py#newcode133
PRESUBMIT.py:133: return results
On 2014/01/31 16:21:58, borenet wrote:
> Seems like there should be a more robust way of doing this.  It's a little
scary
> to depend on the Rietveld format.

Which format? the format of the subject? there is really no other way of
determining it is a CL generated by one-click revert. I also made the variable
name generic to hint that it could be applied to any CL created with 'Revert of'
subject prefix.

[borenet, 2014-01-31 16:27:36]

https://codereview.chromium.org/151573002/diff/70001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/151573002/diff/70001/PRESUBMIT.py#newcode133
PRESUBMIT.py:133: return results
On 2014/01/31 16:24:00, rmistry wrote:
> On 2014/01/31 16:21:58, borenet wrote:
> > Seems like there should be a more robust way of doing this.  It's a little
> scary
> > to depend on the Rietveld format.
> 
> Which format? the format of the subject? there is really no other way of
> determining it is a CL generated by one-click revert. I also made the variable
> name generic to hint that it could be applied to any CL created with 'Revert
of'
> subject prefix.

Yeah.  I think this is okay, but I wish there was a better way.  For the record,
I see a lot of manual revert CLs which use this formats:

Revert "Original subject"
Revert 11234

So it may be better to change the prefix to just "Revert" (and maybe not worry
about case)

[rmistry, 2014-01-31 17:29:42]

https://codereview.chromium.org/151573002/diff/70001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/151573002/diff/70001/PRESUBMIT.py#newcode133
PRESUBMIT.py:133: return results
On 2014/01/31 16:27:36, borenet wrote:
> On 2014/01/31 16:24:00, rmistry wrote:
> > On 2014/01/31 16:21:58, borenet wrote:
> > > Seems like there should be a more robust way of doing this.  It's a little
> > scary
> > > to depend on the Rietveld format.
> > 
> > Which format? the format of the subject? there is really no other way of
> > determining it is a CL generated by one-click revert. I also made the
variable
> > name generic to hint that it could be applied to any CL created with 'Revert
> of'
> > subject prefix.
> 
> Yeah.  I think this is okay, but I wish there was a better way.  For the
record,
> I see a lot of manual revert CLs which use this formats:
> 
> Revert "Original subject"
> Revert 11234
> 
> So it may be better to change the prefix to just "Revert" (and maybe not worry
> about case)

That makes sense, done.

[borenet, 2014-01-31 17:30:30]

LGTM

[rmistry, 2014-01-31 17:32:51]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2014-01-31 17:33:00]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/rmistry@google.com/151573002/140001

[commit-bot: I haz the power, 2014-01-31 17:33:07]

Change committed as 13270

[commit-bot: I haz the power, 2014-01-31 17:33:14]

CQ bit was unchecked on CL. Ignoring.