chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc - Issue 1515703005: WebRequest API: add more resource types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc

Issue 1515703005: WebRequest API: add more resource types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comment, move logical negation Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_apitest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc » ('j') | content/public/common/resource_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc b/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc

index 98f29d450acecb21efcf739b213a3687e21cfda0..82ed2cd2477380fa5e028c115b484c8bc1402a82 100644

--- a/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc

@@ -145,6 +145,7 @@ bool OffDomainInclusionDetector::ShouldAnalyzeRequest(

case content::RESOURCE_TYPE_OBJECT:

case content::RESOURCE_TYPE_MEDIA:

case content::RESOURCE_TYPE_XHR:

+ case content::RESOURCE_TYPE_PLUGIN_RESOURCE:

// Types above are to be analyzed for off-domain inclusion if they are

// loaded as part of the main frame.

return request_info->IsMainFrame();

@@ -154,6 +155,7 @@ bool OffDomainInclusionDetector::ShouldAnalyzeRequest(

case content::RESOURCE_TYPE_FAVICON:

case content::RESOURCE_TYPE_PING:

case content::RESOURCE_TYPE_SERVICE_WORKER:

+ case content::RESOURCE_TYPE_CSP_REPORT:

// Types above are not to be analyzed for off-domain inclusion.

return false;

case content::RESOURCE_TYPE_LAST_TYPE: