Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 15157002: Begin moving DeprecatedStyleBuilder properties to new generated StyleBuilder. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/StyleResolver.cpp
diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp
index e90aeae397cabdea1364abb4bccc919c5c48c354..e2066dc1e7dcf277ed31e20aa7450d1bde988c3a 100644
--- a/Source/core/css/resolver/StyleResolver.cpp
+++ b/Source/core/css/resolver/StyleResolver.cpp
@@ -78,6 +78,7 @@
#include "core/css/WebKitCSSKeyframesRule.h"
#include "core/css/WebKitCSSRegionRule.h"
#include "core/css/resolver/FilterOperationResolver.h"
+#include "core/css/resolver/StyleBuilder.h"
#include "core/css/resolver/TransformBuilder.h"
#include "core/css/resolver/ViewportStyleResolver.h"
#include "core/dom/Attribute.h"
@@ -2433,6 +2434,10 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value)
return;
}
+ // Use the new StyleBuilder. Eventually we'll move away everything after this call.
+ if (StyleBuilder::applyProperty(id, this, value, isInitial, isInherit))
+ return;
+
// Check lookup table for implementations and use when available.
const PropertyHandler& handler = m_styleBuilder.propertyHandler(id);
if (handler.isValid()) {
@@ -3034,7 +3039,7 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value)
case CSSPropertyTransitionProperty:
case CSSPropertyTransitionTimingFunction:
return;
- // These properties are implemented in the DeprecatedStyleBuilder lookup table.
+ // These properties are implemented in the DeprecatedStyleBuilder lookup table or in the new StyleBuilder.
case CSSPropertyBackgroundAttachment:
case CSSPropertyBackgroundBlendMode:
case CSSPropertyBackgroundClip:

Powered by Google App Engine
This is Rietveld 408576698