Roll WebRTC 10903:10978, Libjingle 10903:10977

Roll WebRTC 10903:10978, Libjingle 10903:10977

WebRTC 10903:10978

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/118aa04..090af54

Libjingle 10903:10977

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/917ba7e..5a04232

TBR=
BUG=

Committed: https://crrev.com/49be26736a23ed82f9ae0f427df4aad512c4132e
Cr-Commit-Position: refs/heads/master@{#364505}

[tommi (sloooow) - chröme, 2015-12-10 20:54:13]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2015-12-10 20:55:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1515673005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1515673005/1

[commit-bot: I haz the power, 2015-12-10 22:28:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-10 22:29:21]

Description was changed from

==========
Roll WebRTC 10903:10978, Libjingle 10903:10977

WebRTC 10903:10978

Changes:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/118aa...

Libjingle 10903:10977

Changes:
https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/917ba7e...

TBR=
BUG=
==========

to

==========
Roll WebRTC 10903:10978, Libjingle 10903:10977

WebRTC 10903:10978

Changes:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/118aa...

Libjingle 10903:10977

Changes:
https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/917ba7e...

TBR=
BUG=

Committed: https://crrev.com/49be26736a23ed82f9ae0f427df4aad512c4132e
Cr-Commit-Position: refs/heads/master@{#364505}
==========

[commit-bot: I haz the power, 2015-12-10 22:29:22]

Patchset 1 (id:??) landed as
https://crrev.com/49be26736a23ed82f9ae0f427df4aad512c4132e
Cr-Commit-Position: refs/heads/master@{#364505}

[Nico, 2015-12-10 23:42:35]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-12-10 23:42:35]

This breaks clang/win:
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29/bui...
FAILED: ninja -t msvc -e environment.x86 --
"..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo
/showIncludes /FC
@obj\third_party\webrtc\base\rtc_base_approved.event_tracer.obj.rsp /c
..\..\third_party\webrtc\base\event_tracer.cc
/Foobj\third_party\webrtc\base\rtc_base_approved.event_tracer.obj
/Fdobj\third_party\webrtc\base\rtc_base_approved.cc.pdb 
..\..\third_party\webrtc\base\event_tracer.cc(124,46) :  error: format specifies
type 'int' but the argument has type 'rtc::PlatformThreadId' (aka 'unsigned
long') [-Werror,-Wformat]
                e.phase, e.timestamp, e.pid, e.tid);
                                             ^~~~~
1 error generated.

The fix is easy, see https://codereview.webrtc.org/1457383002/#msg63

Can you fix upstream and quickly roll forward to the fix, or revert in the
meantime?

[hans, 2015-12-11 00:27:59]

On 2015/12/10 23:42:35, Nico wrote:
> This breaks clang/win:
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29/bui...
> FAILED: ninja -t msvc -e environment.x86 --
> "..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo
> /showIncludes /FC
> @obj\third_party\webrtc\base\rtc_base_approved.event_tracer.obj.rsp /c
> ..\..\third_party\webrtc\base\event_tracer.cc
> /Foobj\third_party\webrtc\base\rtc_base_approved.event_tracer.obj
> /Fdobj\third_party\webrtc\base\rtc_base_approved.cc.pdb 
> ..\..\third_party\webrtc\base\event_tracer.cc(124,46) :  error: format
specifies
> type 'int' but the argument has type 'rtc::PlatformThreadId' (aka 'unsigned
> long') [-Werror,-Wformat]
>                 e.phase, e.timestamp, e.pid, e.tid);
>                                              ^~~~~
> 1 error generated.
> 
> The fix is easy, see https://codereview.webrtc.org/1457383002/#msg63
> 
> Can you fix upstream and quickly roll forward to the fix, or revert in the
> meantime?

The fix is in: https://codereview.webrtc.org/1514253002/
Working on getting it rolled.

[hans, 2015-12-11 02:25:33]

On 2015/12/11 00:27:59, hans wrote:
> On 2015/12/10 23:42:35, Nico wrote:
> > This breaks clang/win:
> >
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29/bui...
> > FAILED: ninja -t msvc -e environment.x86 --
> > "..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo
> > /showIncludes /FC
> > @obj\third_party\webrtc\base\rtc_base_approved.event_tracer.obj.rsp /c
> > ..\..\third_party\webrtc\base\event_tracer.cc
> > /Foobj\third_party\webrtc\base\rtc_base_approved.event_tracer.obj
> > /Fdobj\third_party\webrtc\base\rtc_base_approved.cc.pdb 
> > ..\..\third_party\webrtc\base\event_tracer.cc(124,46) :  error: format
> specifies
> > type 'int' but the argument has type 'rtc::PlatformThreadId' (aka 'unsigned
> > long') [-Werror,-Wformat]
> >                 e.phase, e.timestamp, e.pid, e.tid);
> >                                              ^~~~~
> > 1 error generated.
> > 
> > The fix is easy, see https://codereview.webrtc.org/1457383002/#msg63
> > 
> > Can you fix upstream and quickly roll forward to the fix, or revert in the
> > meantime?
> 
> The fix is in: https://codereview.webrtc.org/1514253002/
> Working on getting it rolled.

I cast the wrong field :-( Double checked that it built on Linux but not that it
actually fixed the thing on Windows. Not sure there's anyone around to land the
proper fix now, but I'll try.

[hans, 2015-12-11 02:40:47]

On 2015/12/11 02:25:33, hans wrote:
> I cast the wrong field :-( Double checked that it built on Linux but not that
it
> actually fixed the thing on Windows. Not sure there's anyone around to land
the
> proper fix now, but I'll try.

https://codereview.webrtc.org/1520493003

Haven't found anyone to land it yet.

[hans, 2015-12-11 05:08:50]

On 2015/12/11 02:40:47, hans wrote:
> On 2015/12/11 02:25:33, hans wrote:
> > I cast the wrong field :-( Double checked that it built on Linux but not
that
> it
> > actually fixed the thing on Windows. Not sure there's anyone around to land
> the
> > proper fix now, but I'll try.
> 
> https://codereview.webrtc.org/1520493003
> 
> Haven't found anyone to land it yet.

Landed, and rolled in https://codereview.chromium.org/1513123004
Sorry for the mess.

[tommi (sloooow) - chröme, 2015-12-11 13:07:26]

On 2015/12/11 05:08:50, hans wrote:
> On 2015/12/11 02:40:47, hans wrote:
> > On 2015/12/11 02:25:33, hans wrote:
> > > I cast the wrong field :-( Double checked that it built on Linux but not
> that
> > it
> > > actually fixed the thing on Windows. Not sure there's anyone around to
land
> > the
> > > proper fix now, but I'll try.
> > 
> > https://codereview.webrtc.org/1520493003
> > 
> > Haven't found anyone to land it yet.
> 
> Landed, and rolled in https://codereview.chromium.org/1513123004
> Sorry for the mess.

Thanks for fixing this Hans! :D