Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1515653002: Fix problem with flag unknown to clang. (Closed)

Created:
5 years ago by herb_g
Modified:
5 years ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix problem with flag unknown to clang. This negates an earlier -Werror causing warnings to be errors. BUG=skia: Committed: https://skia.googlesource.com/skia/+/39cbd2b30c621fb94921d59b9fd1d5206921e367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gyp/codec.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
herb_g
5 years ago (2015-12-09 18:39:08 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515653002/1
5 years ago (2015-12-09 18:39:25 UTC) #5
msarett
lgtm I'd like to try to figure out why/if we need that flag.
5 years ago (2015-12-09 18:43:46 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 19:37:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515653002/1
5 years ago (2015-12-09 20:26:53 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-09 20:27:33 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/39cbd2b30c621fb94921d59b9fd1d5206921e367

Powered by Google App Engine
This is Rietveld 408576698