Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1515613009: Stage destructuring assignment (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage destructuring assignment BUG=v8:811 LOG=y Committed: https://crrev.com/c6e7d658e5e080bee8d653f50b1df8d1b1e1ad85 Cr-Commit-Position: refs/heads/master@{#32905}

Patch Set 1 #

Patch Set 2 : Update after 4613 fixed #

Patch Set 3 : Rebased #

Patch Set 4 : Skip tests in ignition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M src/flag-definitions.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M test/test262/test262.status View 1 2 3 3 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
adamk
5 years ago (2015-12-16 10:57:02 UTC) #3
rossberg
lgtm
5 years ago (2015-12-16 13:15:36 UTC) #4
Michael Hablich
On 2015/12/16 13:15:36, rossberg wrote: > lgtm You need to create a new patchset because ...
5 years ago (2015-12-16 13:24:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515613009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515613009/40001
5 years ago (2015-12-16 13:28:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11582)
5 years ago (2015-12-16 13:52:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515613009/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515613009/60001
5 years ago (2015-12-16 14:26:54 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-16 14:51:32 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-16 14:51:47 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c6e7d658e5e080bee8d653f50b1df8d1b1e1ad85
Cr-Commit-Position: refs/heads/master@{#32905}

Powered by Google App Engine
This is Rietveld 408576698