chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm - Issue 1515553006: Change password bubble for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Issue 1515553006: Change password bubble for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, clean-up Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm ('K') | « chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.h ('k') | chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm » ('j') | chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

index 6113068e86f9ac94566539628da471516a5d6db6..1b7ff8e4346fc1acd015eb4a566da160b640ed32 100644

--- a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

@@ -39,6 +39,8 @@ initWithModel:(ManagePasswordsBubbleModel*)model

}

- (NSView*)createPasswordView {

+ if (self.model->pending_password().username_value.empty())

+ return nil;

vasilii 2015/12/15 15:58:02 A new test for this required.

dvadym 2015/12/16 14:16:31 Tests SavePendingPasswordViewControllerTest.Should

std::vector<const autofill::PasswordForm*> password_forms;

password_forms.push_back(&self.model->pending_password());

passwordItem_.reset([[PasswordsListViewController alloc]