chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm - Issue 1515553006: Change password bubble for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm

Issue 1515553006: Change password bubble for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, clean-up Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/passwords/credentials_selection_view.mm ('K') | « chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/passwords/passwords_list_view_controller_unittest.mm » ('j') | chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm b/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm

index 510ce4de6208f39812684277a68656a49f227088..653547d8d61f543d6f28d083165916fd4695f9c0 100644

--- a/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm

@@ -286,7 +286,9 @@ NSTextField* FederationLabel(const base::string16& text) {

delegate_ = delegate;

passwordForm_ = passwordForm;

if ([delegate_ model]->state() ==

- password_manager::ui::PENDING_PASSWORD_STATE)

+ password_manager::ui::PENDING_PASSWORD_STATE ||

+ [delegate_ model]->state() ==

+ password_manager::ui::PENDING_PASSWORD_UPDATE_STATE)

vasilii 2015/12/15 15:58:01 Why do you need the new state here?

dvadym 2015/12/16 14:16:31 Because PasswordsListViewController is used in the

vasilii 2015/12/16 18:10:57 Acknowledged.

state_ = MANAGE_PASSWORD_ITEM_STATE_PENDING;

else

state_ = MANAGE_PASSWORD_ITEM_STATE_MANAGE;