chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm - Issue 1515553006: Change password bubble for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm

Issue 1515553006: Change password bubble for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, clean-up Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h ('k') | chrome/browser/ui/cocoa/passwords/credentials_selection_view.h » ('j') | chrome/browser/ui/cocoa/passwords/credentials_selection_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm

diff --git a/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm b/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm

index b6a7c9f50e328daee02a552725d37c2a0d400c4b..f971cc785c5bf0b927a5d6ae442a90adf1c10e9d 100644

--- a/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm

+++ b/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm

@@ -48,7 +48,7 @@ ManagePasswordsControllerTest::GetModelAndCreateIfNull() {

return model_.get();

}

-void ManagePasswordsControllerTest::SetUpPendingState() {

+void ManagePasswordsControllerTest::SetUpPendingState(bool update) {

autofill::PasswordForm form;

EXPECT_CALL(*ui_controller_, GetPendingPassword()).WillOnce(ReturnRef(form));

std::vector<const autofill::PasswordForm*> forms;

@@ -56,7 +56,9 @@ void ManagePasswordsControllerTest::SetUpPendingState() {

GURL origin(kSiteOrigin);

EXPECT_CALL(*ui_controller_, GetOrigin()).WillOnce(ReturnRef(origin));

EXPECT_CALL(*ui_controller_, GetState())

- .WillOnce(Return(password_manager::ui::PENDING_PASSWORD_STATE));

+ .WillOnce(Return(update

+ ? password_manager::ui::PENDING_PASSWORD_UPDATE_STATE

+ : password_manager::ui::PENDING_PASSWORD_STATE));

GetModelAndCreateIfNull();

ASSERT_TRUE(testing::Mock::VerifyAndClearExpectations(ui_controller_));

}