Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1515553006: Change password bubble for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, clean-up Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 5 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 // The bubble should be the default case that runs on the bots. 491 // The bubble should be the default case that runs on the bots.
492 return group_name != "Infobar"; 492 return group_name != "Infobar";
493 #else 493 #else
494 // All other platforms use Aura, and therefore always show the bubble. 494 // All other platforms use Aura, and therefore always show the bubble.
495 return true; 495 return true;
496 #endif 496 #endif
497 } 497 }
498 498
499 bool ChromePasswordManagerClient::IsUpdatePasswordUIEnabled() const { 499 bool ChromePasswordManagerClient::IsUpdatePasswordUIEnabled() const {
500 #if defined(OS_MACOSX) 500 #if defined(OS_MACOSX)
501 return false; 501 if (!ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled()) {
502 // Currently Password update UI is implemented only for Bubble UI.
503 return false;
504 }
505 return base::FeatureList::IsEnabled(
506 password_manager::features::kEnablePasswordChangeSupport);
502 #else 507 #else
503 return IsTheHotNewBubbleUIEnabled(); 508 return IsTheHotNewBubbleUIEnabled();
504 #endif 509 #endif
505 } 510 }
506 511
507 bool ChromePasswordManagerClient::EnabledForSyncSignin() { 512 bool ChromePasswordManagerClient::EnabledForSyncSignin() {
508 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); 513 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
509 if (command_line->HasSwitch( 514 if (command_line->HasSwitch(
510 password_manager::switches::kDisableManagerForSyncSignin)) 515 password_manager::switches::kDisableManagerForSyncSignin))
511 return false; 516 return false;
(...skipping 24 matching lines...) Expand all
536 541
537 const password_manager::CredentialsFilter* 542 const password_manager::CredentialsFilter*
538 ChromePasswordManagerClient::GetStoreResultFilter() const { 543 ChromePasswordManagerClient::GetStoreResultFilter() const {
539 return &credentials_filter_; 544 return &credentials_filter_;
540 } 545 }
541 546
542 const password_manager::LogManager* ChromePasswordManagerClient::GetLogManager() 547 const password_manager::LogManager* ChromePasswordManagerClient::GetLogManager()
543 const { 548 const {
544 return log_manager_.get(); 549 return log_manager_.get();
545 } 550 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698