components/autofill/core/browser/form_field_unittest.cc - Issue 1515553005: Label non-capturing groups if no capturing needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_field_unittest.cc

Issue 1515553005: Label non-capturing groups if no capturing needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/form_field_unittest.cc

diff --git a/components/autofill/core/browser/form_field_unittest.cc b/components/autofill/core/browser/form_field_unittest.cc

index aac94d07dfbd082bbaeb48b60d45f1a14323fee9..61ebaa3eb3b4edc7ae15c82c9c1e6e0b2e19cd8d 100644

--- a/components/autofill/core/browser/form_field_unittest.cc

+++ b/components/autofill/core/browser/form_field_unittest.cc

@@ -88,7 +88,7 @@ TEST(FormFieldTest, Match) {

EXPECT_TRUE(FormField::Match(&field, "head_tail", FormField::MATCH_LABEL));

// Word boundaries.

- const std::string kWordBoundary = "(\\A|\\z|\\PL)";

+ const std::string kWordBoundary = "(?:\\A|\\z|\\PL)";

field.label = ASCIIToUTF16("contains word:");

EXPECT_TRUE(FormField::Match(&field, kWordBoundary + "word" + kWordBoundary,

FormField::MATCH_LABEL));