Label non-capturing groups if no capturing needed

Label non-capturing groups if no capturing needed

Without this patch, a new version of RE2 (not checked in, yet) runs out of memory:
../../third_party/re2/re2/dfa.cc:469: DFA out of memory: prog size 17637 mem 2725434

BUG=568564, 568134
Committed: https://crrev.com/dd739e8bd477dd6c45e64630320adfd99ca54d4c
Cr-Commit-Position: refs/heads/master@{#364354}

[battre, 2015-12-10 14:04:08]

Description was changed from

==========
Label non-capturing groups if no capturing needed

BUG=568564
==========

to

==========
Label non-capturing groups if no capturing needed

Without this patch, a new version of RE2 (not checked in, yet) runs out of
memory:
../../third_party/re2/re2/dfa.cc:469: DFA out of memory: prog size 17637 mem
2725434

BUG=568564, 568134
==========

[battre, 2015-12-10 14:04:08]

battre@chromium.org changed reviewers:
+ vabr@google.com

[vabr (Chromium), 2015-12-10 14:07:01]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-12-10 14:07:02]

LGTM, thanks!

Thiago, Ilya, Evan -- FYI, as you were also involved in the recent regexp
changes.

https://codereview.chromium.org/1515553005/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_regex_constants.cc (right):

https://codereview.chromium.org/1515553005/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_regex_constants.cc:182:
"|ablaufdatum|gueltig|gültig|jahr"  // de-DE
Yawohl! :)

[battre, 2015-12-10 14:11:02]

The CQ bit was checked by battre@chromium.org

[commit-bot: I haz the power, 2015-12-10 14:11:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1515553005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1515553005/1

[commit-bot: I haz the power, 2015-12-10 14:28:32]

Description was changed from

==========
Label non-capturing groups if no capturing needed

Without this patch, a new version of RE2 (not checked in, yet) runs out of
memory:
../../third_party/re2/re2/dfa.cc:469: DFA out of memory: prog size 17637 mem
2725434

BUG=568564, 568134
==========

to

==========
Label non-capturing groups if no capturing needed

Without this patch, a new version of RE2 (not checked in, yet) runs out of
memory:
../../third_party/re2/re2/dfa.cc:469: DFA out of memory: prog size 17637 mem
2725434

BUG=568564, 568134
==========

[commit-bot: I haz the power, 2015-12-10 14:28:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-10 14:29:28]

Description was changed from

==========
Label non-capturing groups if no capturing needed

Without this patch, a new version of RE2 (not checked in, yet) runs out of
memory:
../../third_party/re2/re2/dfa.cc:469: DFA out of memory: prog size 17637 mem
2725434

BUG=568564, 568134
==========

to

==========
Label non-capturing groups if no capturing needed

Without this patch, a new version of RE2 (not checked in, yet) runs out of
memory:
../../third_party/re2/re2/dfa.cc:469: DFA out of memory: prog size 17637 mem
2725434

BUG=568564, 568134

Committed: https://crrev.com/dd739e8bd477dd6c45e64630320adfd99ca54d4c
Cr-Commit-Position: refs/heads/master@{#364354}
==========

[commit-bot: I haz the power, 2015-12-10 14:29:29]

Patchset 1 (id:??) landed as
https://crrev.com/dd739e8bd477dd6c45e64630320adfd99ca54d4c
Cr-Commit-Position: refs/heads/master@{#364354}

[tfarina, 2015-12-10 18:25:38]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2015-12-10 18:25:38]

Reverting this, to then revert my CL.

[tfarina, 2015-12-10 18:27:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1515963003/ by tfarina@chromium.org.

The reason for reverting is: It does not solve the memory perf regression. Will
also revert the other CL..

[Evan Stade, 2015-12-10 18:43:27]

On 2015/12/10 18:27:27, tfarina wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1515963003/ by mailto:tfarina@chromium.org.
> 
> The reason for reverting is: It does not solve the memory perf regression.
Will
> also revert the other CL..

it seems like some parts of this CL could/should be salvaged

[vabr (Chromium), 2015-12-11 08:09:08]

On 2015/12/10 18:43:27, Evan Stade wrote:
> On 2015/12/10 18:27:27, tfarina wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1515963003/ by mailto:tfarina@chromium.org.
> > 
> > The reason for reverting is: It does not solve the memory perf regression.
> Will
> > also revert the other CL..
> 
> it seems like some parts of this CL could/should be salvaged

Indeed. I'll create a CL to fix that.