runtime/vm/os_thread.cc - Issue 1515553003: VM: Fix deadlock in time line recording.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/os_thread.cc

Issue 1515553003: VM: Fix deadlock in time line recording. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/os_thread.cc

diff --git a/runtime/vm/os_thread.cc b/runtime/vm/os_thread.cc

index 3789a60140a269b738a4ccdd5ebedbe8f3834573..5450de1b0e2ba3f94e1982662df5a536a59f78fa 100644

--- a/runtime/vm/os_thread.cc

+++ b/runtime/vm/os_thread.cc

@@ -24,7 +24,7 @@ OSThread::OSThread() :

join_id_(OSThread::GetCurrentThreadJoinId()),

trace_id_(OSThread::GetCurrentThreadTraceId()),

name_(NULL),

- timeline_block_lock_(new Mutex()),

+ timeline_block_lock_(new Mutex(/* recursive = */ true)),

timeline_block_(NULL),

thread_list_next_(NULL),

thread_interrupt_disabled_(1), // Thread interrupts disabled by default.